fix(validator): move valid_solved increment after exclusion guards#1299
Open
enjoyandlove wants to merge 1 commit into
Open
fix(validator): move valid_solved increment after exclusion guards#1299enjoyandlove wants to merge 1 commit into
enjoyandlove wants to merge 1 commit into
Conversation
Author
|
Hi, @anderdc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1298
Move the
valid_solvedincrement after the same-account and non-canonical exclusion guards in_score_miner_issues. Previously,acc.valid_solvedwas incremented before these guards ran, which allowed excluded issues (same-account solvers, non-canonical PRs) to inflate the counter and inadvertently satisfy the per-repository eligibility threshold. The counter now only increments for issues that pass all exclusion checks.Related Issues
Type of Change
Testing
Checklist